From e8557bd25fdcfb2afb1ae32228539345e7482b6f Mon Sep 17 00:00:00 2001 From: davidmonterocrespo24 Date: Fri, 15 May 2026 23:42:52 +0200 Subject: [PATCH] =?UTF-8?q?ci:=20fix=20Frontend=20Tests=20=E2=80=94=20use?= =?UTF-8?q?=20build:docker=20instead=20of=20build?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Vite production build step was running `npm run build` which includes `tsc -b` in its chain. The repo has ~100 pre-existing strict TS errors (TS6133 unused vars, TS1294 erasableSyntaxOnly, JSX intrinsic-element types for custom elements) gated by the separate `tsc` step above with continue-on-error. `build:docker` is the script the Dockerfile actually uses to ship prod — it runs generate:component-svgs + generate:sitemap + vite build + prerender-seo. It skips `tsc -b` for the same reason the workflow's `tsc` step is continue-on-error. Verified locally: 285 SEO pages prerendered, vite build green. --- .github/workflows/frontend-tests.yml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/frontend-tests.yml b/.github/workflows/frontend-tests.yml index 7abb8788..c22fbab7 100644 --- a/.github/workflows/frontend-tests.yml +++ b/.github/workflows/frontend-tests.yml @@ -71,8 +71,16 @@ jobs: # Production build smoke — catches Vite/Rollup-only failures that # vitest doesn't see (chunk wiring, dynamic imports, manualChunks # config, asset resolution). + # + # Use `build:docker` (not `build`): the latter runs `tsc -b` first + # which has pre-existing strict errors (TS6133 unused, TS1294 + # erasableSyntaxOnly, JSX intrinsic-element types from custom + # elements). Those are tracked separately and gated by the `tsc` + # step above with continue-on-error. The Dockerfile in production + # uses `build:docker` too — this step now matches what actually + # ships. - name: Vite production build - run: cd frontend && npm run build + run: cd frontend && npm run build:docker # Upload coverage as an artifact for download / inspection. Skip # codecov for now (no org account). Run only on Node 22 to keep the