a2nr
/
velxio
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: prevent save to /api/projects/none when project ID is invalid 

Two bugs causing "can't save project" reports:

1. SaveProjectModal: validate currentProject.id is a real UUID before
   calling updateProject. If id is "none" or any non-UUID string, fall
   through to createProject instead, avoiding PUT /api/projects/none.

2. ProjectByIdPage: call clearCurrentProject() when the project fetch
   fails (404/403/error). Prevents stale project IDs from a previous
   session polluting the store and triggering spurious update calls.
This commit is contained in:
David Montero 2026-04-09 02:34:43 +02:00
parent f43c9d019d
commit 6c95013f24
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
frontend/src/components/layout/SaveProjectModal.tsx
View File

@ -58,15 +58,19 @@ export const SaveProjectModal: React.FC<SaveProjectModalProps> = ({ onClose }) =
wires_json: JSON.stringify(wires),
};
const UUID_RE = /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/i;
const isValidUpdate = isUpdate && currentProject && UUID_RE.test(currentProject.id);
try {
let saved;
if (isUpdate && currentProject) {
saved = await updateProject(currentProject.id, payload);
if (isValidUpdate) {
saved = await updateProject(currentProject!.id, payload);
trackSaveProject();
} else {
saved = await createProject(payload);
trackCreateProject();
}
setCurrentProject({
id: saved.id,
slug: saved.slug,

2
frontend/src/pages/ProjectByIdPage.tsx
View File

@ -19,6 +19,7 @@ export const ProjectByIdPage: React.FC = () => {
const loadFiles = useEditorStore((s) => s.loadFiles);
const { setComponents, setWires, setBoardType } = useSimulatorStore();
const setCurrentProject = useProjectStore((s) => s.setCurrentProject);
const clearCurrentProject = useProjectStore((s) => s.clearCurrentProject);
const currentProject = useProjectStore((s) => s.currentProject);
const [ready, setReady] = useState(false);
const [error, setError] = useState('');
@ -56,6 +57,7 @@ export const ProjectByIdPage: React.FC = () => {
if (s === 404) setError('Project not found.');
else if (s === 403) setError('This project is private.');
else setError('Failed to load project.');
clearCurrentProject();
});
}, [id]);